Change in vdsm[master]: LiveMerge: Add support for deleting merged volumes
Federico Simoncelli
fsimonce at redhat.com
Mon Jun 9 12:55:27 UTC 2014
Federico Simoncelli has posted comments on this change.
Change subject: LiveMerge: Add support for deleting merged volumes
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.ovirt.org/#/c/26768/4/vdsm/storage/blockVolume.py
File vdsm/storage/blockVolume.py:
Line 199:
Line 200: # Check for a stale parent UUID in the volume tags and correct it.
Line 201: # This happens after a live merge finishes since we cannot update LV
Line 202: # tags as HSM.
Line 203: children = self.getChildren()
> getChildren() and BlockVolume() production are going to to take place for e
deleteImage is implemented differently (it's not relying on calling volume.delete on each volume).
Line 204: if children:
Line 205: child = BlockVolume(self.repoPath, self.sdUUID, self.imgUUID,
Line 206: children[0])
Line 207: metaParent = child.getMetaParam(volume.PUUID)
Line 202: # tags as HSM.
Line 203: children = self.getChildren()
Line 204: if children:
Line 205: child = BlockVolume(self.repoPath, self.sdUUID, self.imgUUID,
Line 206: children[0])
> possibly-silly question: are we sure there is no snapshot (a second child)
yes, here we need to loop on all the children.
Line 207: metaParent = child.getMetaParam(volume.PUUID)
Line 208: tagParent = child.getParent()
Line 209: if metaParent != tagParent:
Line 210: self.log.debug("Updating stale PUUID LV tag from %s to %s for "
--
To view, visit http://gerrit.ovirt.org/26768
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf43f65f984d7f76622454dc8877d56ef8dedb8f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list