Change in vdsm[master]: utils: add isOvirtNode function.

Alon Bar-Lev alonbl at redhat.com
Mon Jun 9 10:12:30 UTC 2014


Alon Bar-Lev has posted comments on this change.

Change subject: utils: add isOvirtNode function.
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/28486/1/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 1105:     sys.exit(-3)
Line 1106: 
Line 1107: 
Line 1108: @memoized
Line 1109: def isOvirtNode():
if you are going to use the new apis, I guess there should be more standard way of obtaining the information by import one of the packages and calling something. we should stop performing this check physically.
Line 1110:     return (
Line 1111:         os.path.exists('/etc/rhev-hypervisor-release') or
Line 1112:         glob.glob('/etc/ovirt-node-*-release')
Line 1113:     )


-- 
To view, visit http://gerrit.ovirt.org/28486
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I82207f674f9d1854f9fdddd0804de611073a794c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list