Change in vdsm[master]: replace configure_libvirt.py with python code.

ybronhei at redhat.com ybronhei at redhat.com
Sun Jun 8 13:23:20 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: replace configure_libvirt.py with python code.
......................................................................


Patch Set 23: Code-Review+1

(1 comment)

hope i haven't miss more changes .  but expect the naming, it seems alright

http://gerrit.ovirt.org/#/c/27298/23/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 36:     SANLOCK_ENABLED, LIBVIRT_SELINUX, P_VDSM
Line 37: from vdsm.config import config
Line 38: 
Line 39: if utils.isOvirtNode:
Line 40:     from ovirt.node.utils.fs import Config
import as nodeCfg will be more easier to understand imo
Line 41: 
Line 42: 
Line 43: class InvalidConfig(UsageError):
Line 44:     """ raise when invalid configuration passed """


-- 
To view, visit http://gerrit.ovirt.org/27298
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74bfe05bb4b5f5d09021f21b324f9b7d5d0fdaab
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list