Change in vdsm[master]: json-rpc: Protocol detection

ybronhei at redhat.com ybronhei at redhat.com
Sat Jun 7 17:45:13 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: json-rpc: Protocol detection
......................................................................


Patch Set 34:

(1 comment)

http://gerrit.ovirt.org/#/c/26300/34/vdsm/protocolDetector.py
File vdsm/protocolDetector.py:

Line 172:     def _handle_connection_read(self, fd):
Line 173:         _, client_socket = self._pending_connections[fd]
Line 174:         try:
Line 175:             data = client_socket.recv(self._required_size, socket.MSG_PEEK)
Line 176:             if data is None:
> A comment explain this unusual return value would be nice.
add comment
Line 177:                 return
Line 178:         except socket.error as e:
Line 179:             if e.errno not in (errno.EAGAIN, errno.EWOULDBLOCK):
Line 180:                 self.log.warning("Unable to read data")


-- 
To view, visit http://gerrit.ovirt.org/26300
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75
Gerrit-PatchSet: 34
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list