Change in vdsm[master]: utils: must unpersist files for remove

danken at redhat.com danken at redhat.com
Sat Jun 7 00:13:47 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: utils: must unpersist files for remove
......................................................................


Patch Set 1: Code-Review-1

rmFile is used too often on files that are never persisted. We should not add an isOvirt test so often.

Could you explain which flow attempts to rmFile a persisted file? Do you understand how did it suddenly pop up?

-- 
To view, visit http://gerrit.ovirt.org/28383
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0507fcbc5338aaf76fecb08ca4e6d84138347ec9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list