Change in vdsm[master]: utils: Correct and faster list2cmdline

Federico Simoncelli fsimonce at redhat.com
Fri Jun 6 23:17:07 UTC 2014


Federico Simoncelli has posted comments on this change.

Change subject: utils: Correct and faster list2cmdline
......................................................................


Patch Set 6: -Code-Review

(1 comment)

http://gerrit.ovirt.org/#/c/27548/6/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 657:     parts = []
Line 658:     for arg in args:
Line 659:         if _needs_quoting(arg) or arg == '':
Line 660:             quoted = ("'" + s + "'" for s in arg.split("'"))
Line 661:             arg = r"\'".join(quoted)
> Nice!
Babysitting other people's patches obviously doesn't scale. Everyone should be proud of trying and improve his own patches and must take responsibility for them. I'll remove my -1 since it is obvious that the "visibility" part worked.
Line 662:         parts.append(arg)
Line 663:     return ' '.join(parts)
Line 664: 
Line 665: 


-- 
To view, visit http://gerrit.ovirt.org/27548
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfc7819c126fe51cc068cc6f9f85b1002878385b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list