Change in vdsm[master]: faqemu hook: move memory limitation to config

mpoledni at redhat.com mpoledni at redhat.com
Thu Jun 5 12:15:53 UTC 2014


Martin Polednik has posted comments on this change.

Change subject: faqemu hook: move memory limitation to config
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/28320/3/vdsm_hooks/faqemu/before_vm_start.py
File vdsm_hooks/faqemu/before_vm_start.py:

Line 32:     memory = config.get('vars', 'fake_kvm_memory', None)
Line 33:     arch = config.get('vars', 'fake_kvm_architecture')
Line 34: 
Line 35:     if memory is None:
Line 36:         if arch == 'x86_64':
> I think ht efirst version was better - I don't particularly like magic numb
Config keys are commented by default, making them more of an indication rather than setting. This way, x86 and ppc is preserved, allowing for setting upper memory limit / using direct vmCreate memory limit.
Line 37:             memory = '20480'
Line 38:         if arch == 'ppc64':
Line 39:             memory = '262144'
Line 40: 


-- 
To view, visit http://gerrit.ovirt.org/28320
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list