Change in vdsm[master]: upgrade_unified: fix for nicless and bridges with vnics

asegurap at redhat.com asegurap at redhat.com
Wed Jun 4 11:55:34 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: upgrade_unified: fix for nicless and bridges with vnics
......................................................................


Patch Set 1:

Verified manually trying several network configurations:

Add nicless net
    toniel602 ~ # vdsClient -s 0 addNetwork bridge=nicless nics= bootproto=none               
    Done
Add bridged, vlanned, bonded network
    toniel602 ~ # vdsClient -s 0 addNetwork bridge=bar nics=eth3,eth4 bonding=bond0 vlan=15
    Done
Add another port to the bridge (simulates having a vnet device)
    toniel602 ~ # ip link add vnet0 link eth1 type macvlan
    toniel602 ~ # brctl addif bar vnet0

Check that the vnet is not reported and that the nicless network does not
report a value-less nic key.
    In [36]: unified_persistence._getNetInfo()
    Out[36]: 
    ({'bar': {'bonding': 'bond0',
              'bridged': True,
              'defaultRoute': False,
              'mtu': 1500,
              'stp': False,
              'vlan': '15'},
      'nicless': {'bridged': True,
                  'defaultRoute': False,
                  'mtu': 1500,
                  'stp': False}},
     {'bond0': {'nics': ['eth3', 'eth4'], 'options': 'mode=802.3ad miimon=150'}})

Try with simple brided and bridgeless networks over a nic:

    toniel602 ~ # vdsClient -s 0 addNetwork bridge=other nics=eth3 bootproto=none
    Done
    toniel602 ~ # vdsClient -s 0 addNetwork bridge=otherbrless nics=eth4 bootproto=none bridged=False   
    Done

    In [18]: unified_persistence._getNetInfo()
    Out[18]: 
    ({'other': {'bridged': True,
                'defaultRoute': False,
                'mtu': 1500,
                'nic': 'eth3',
                'stp': False},
      'otherbrless': {'bridged': False,
                      'defaultRoute': False,
                      'mtu': 1500,
                      'nic': u'eth4'}},
     {})

Then a bridged vlanned:
    toniel602 ~ # vdsClient -s 0 addNetwork bridge=bar nics=eth3 vlan=15
    Done
    In [24]: unified_persistence._getNetInfo()
    Out[24]: 
    ({'bar': {'bridged': True,
              'defaultRoute': False,
              'mtu': 1500,
              'nic': 'eth3',
              'stp': False,
              'vlan': '15'}},
    {})

-- 
To view, visit http://gerrit.ovirt.org/28354
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I979ad260e86865fc7ca9760d58765e4bf0c14c3c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list