Change in vdsm[master]: vm: move getBalloonInfo in the stats thread

danken at redhat.com danken at redhat.com
Tue Jun 3 15:37:43 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: vm: move getBalloonInfo in the stats thread
......................................................................


vm: move getBalloonInfo in the stats thread

To gather the ballon stats, we used to make a direct libvirt
call in the getStats() body. This is dangerous, because
getStats() should not contain costly calls, and should
just gather data.

This patch reimplements the balloon information getter as a
sampling function, and moves it into the VmStatsThread
to make things more robust.

As remainder to avoid to sneak costly calls in getStats,
this patch also adds a docstring in getStatsInternal.

Change-Id: I51fd1268b3718f3cb0c1bb32b13f38a58a67b8be
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/27696
Reviewed-by: Vinzenz Feenstra <vfeenstr at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/config.py.in
M tests/vmTests.py
M vdsm/virt/vm.py
3 files changed, 52 insertions(+), 25 deletions(-)

Approvals:
  Vinzenz Feenstra: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit http://gerrit.ovirt.org/27696
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I51fd1268b3718f3cb0c1bb32b13f38a58a67b8be
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list