Change in vdsm[master]: tests: use 'localhost' explicitly in test
nsoffer at redhat.com
nsoffer at redhat.com
Tue Jun 3 11:46:15 UTC 2014
Nir Soffer has posted comments on this change.
Change subject: tests: use 'localhost' explicitly in test
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/28107/1/tests/functional/storageTests.py
File tests/functional/storageTests.py:
Line 79: isSSL = config.getboolean('vars', 'ssl')
Line 80: if isSSL and os.geteuid() != 0:
Line 81: raise SkipTest("Must be root to use SSL connection to server")
Line 82: address = 'localhost:%s' % config.get('addresses', 'management_port')
Line 83: self.s = vdscli.connect(hostPort=address, useSSL=isSSL)
We can minimize this patch to:
self.s = vdscli.connect(hostPort='localhost', useSSL=isSSL)
Works for me on a host that otherwise fail in this test, for the same reason that Yoav host fails.
Line 84:
Line 85: def assertVdsOK(self, vdsResult):
Line 86: # code == 0 means OK
Line 87: self.assertEquals(
--
To view, visit http://gerrit.ovirt.org/28107
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89990cff46e64120262e250eee9238b49c4edee4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list