Change in vdsm[master]: json-rpc: Protocol detection

nsoffer at redhat.com nsoffer at redhat.com
Tue Jun 3 11:05:52 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: json-rpc: Protocol detection
......................................................................


Patch Set 31:

(2 comments)

http://gerrit.ovirt.org/#/c/26300/31/lib/vdsm/sslUtils.py
File lib/vdsm/sslUtils.py:

Line 77: #             result = self.connection.peek(size)
Line 78: #         else:
Line 79: #             result = self.connection.read(size)
Line 80: #         return result
Line 81: #     recv = read
> rebase/debug relic?
We should remove this commented code later.
Line 82: 
Line 83:     def __getattr__(self, name):
Line 84:         return getattr(self.connection, name)
Line 85: 


http://gerrit.ovirt.org/#/c/26300/31/vdsm/BindingXMLRPC.py
File vdsm/BindingXMLRPC.py:

Line 1131:         self.xml_binding = xml_binding
Line 1132: 
Line 1133:     def detect(self, data):
Line 1134:         return (data.startswith("PUT /") or data.startswith("GET /") or
Line 1135:                 data.startswith("POST /RPC2"))
> I tested xmlrpc by running CI dev job with the latest engine. I tested it o
What do you mean by "there is a / context"?
Line 1136: 
Line 1137:     def handleSocket(self, client_socket, socket_address):
Line 1138:         self.xml_binding.add_socket(client_socket, socket_address)


-- 
To view, visit http://gerrit.ovirt.org/26300
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75
Gerrit-PatchSet: 31
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list