Change in vdsm[master]: resourceManager: Keep resource state if registerResource fails
Federico Simoncelli
fsimonce at redhat.com
Tue Jun 3 08:48:57 UTC 2014
Federico Simoncelli has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/25284/4/vdsm/storage/resourceManager.py
File vdsm/storage/resourceManager.py:
Line 599: resource.activeUsers += 1
Line 600:
Line 601: self._log.debug("Resource '%s' is free. Now locking as '%s' "
Line 602: "(1 active user)", fullName, request.lockType)
Line 603: request.grant()
Does this mean that if something breaks we have a granted request for a resource that wasn't recorded in the "resources" dictionary?
I have the feeling that resources[name] should remain where it was. Or maybe you have to move the RequestRef creation before grant?
Line 604: ref = RequestRef(request)
Line 605: contextCleanup.defer(request.emit,
Line 606: ResourceRef(namespace, name,
Line 607: resource.realObj,
--
To view, visit http://gerrit.ovirt.org/25284
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16abf41ebc8a8a99b292d38c945074752254a34b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel P. Berrange <berrange at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list