Change in vdsm[master]: [WIP]tests: add simple balloon functional testcase

fromani at redhat.com fromani at redhat.com
Tue Jun 3 08:09:57 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: [WIP]tests: add simple balloon functional testcase
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.ovirt.org/#/c/12820/3/tests/functional/virtTests.py
File tests/functional/virtTests.py:

Line 337:                          'devices': [balloonSpec]}
Line 338:         policy = {'balloon': policyStr}
Line 339: 
Line 340:         with RollbackContext() as rollback:
Line 341:             self._runVMKernelBootTemplate(rollback, customization)
> _runVMKernelBootTemplate ?
Historical relic. Fixed doing some archeology.
Line 342:             self._enableBalloonPolicy(policy, rollback)
Line 343:             time.sleep(12)  # MOM policy engine wake up every 10s
Line 344:             balloonInf = self.s.getVmStats(
Line 345:                 customization['vmId'])['statsList'][0]['balloonInfo']


Line 339: 
Line 340:         with RollbackContext() as rollback:
Line 341:             self._runVMKernelBootTemplate(rollback, customization)
Line 342:             self._enableBalloonPolicy(policy, rollback)
Line 343:             time.sleep(12)  # MOM policy engine wake up every 10s
> It's policy-engine-interval, for the record.
Sorry, I'm not following you here. Could you please expand the above sentence?
Line 344:             balloonInf = self.s.getVmStats(
Line 345:                 customization['vmId'])['statsList'][0]['balloonInfo']
Line 346:             self.assertEqual(balloonInf['balloon_cur'], 0)
Line 347: 


-- 
To view, visit http://gerrit.ovirt.org/12820
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8140fe1c754d9d4026c503a19420e6552a3f4fe
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list