Change in vdsm[master]: vdsm: add support for hostdev passthrough

mpoledni at redhat.com mpoledni at redhat.com
Mon Jun 2 09:06:05 UTC 2014


Martin Polednik has posted comments on this change.

Change subject: vdsm: add support for hostdev passthrough
......................................................................


Patch Set 7:

(2 comments)

http://gerrit.ovirt.org/#/c/22462/7/vdsm/caps.py
File vdsm/caps.py:

Line 325:         # representation of the device
Line 326:         try:
Line 327:             dev['name'] = devXML.getElementsByTagName('name')[0].\
Line 328:                 childNodes[0].data
Line 329:             capability = devXML.getElementsByTagName('capability')[0]
> please consider enhancements in http://gerrit.ovirt.org/#/c/14237 as well, 
Current implementation's display capabilities are equivalent of virt-manager's, do we want to add lspci parsing? We'd need whole lspci as dependancy.
Line 330:             try:
Line 331:                 dev['product'] = capability.getElementsByTagName('product')[0]\
Line 332:                     .childNodes[0].data
Line 333:                 dev['vendor'] = capability.getElementsByTagName('vendor')[0].\


http://gerrit.ovirt.org/#/c/22462/7/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1405:             <source startupPolicy='optional'>
Line 1406:                 <vendor id='0x1234'/>
Line 1407:                 <product id='0xbeef'/>
Line 1408:             </source>
Line 1409:             <boot order='2'/>
> does it do startupPolicy?
I've missed this but libvirt indeed allows hostdev's to be bootable devices, I'll look at possible integration in future patch (might need to be similar to network in hostdev handling)
Line 1410:             </hostdev>
Line 1411:         </devices>
Line 1412:         """
Line 1413:         # libvirt gives us direct api call to construct the XML


-- 
To view, visit http://gerrit.ovirt.org/22462
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I363d2622d72ca2db75f60032fe0892c348bab121
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list