Change in vdsm[master]: hsm: deleteImage - lock image by imgUUID and sdUUID

laravot at redhat.com laravot at redhat.com
Mon Jun 2 07:53:10 UTC 2014


Liron Ar has posted comments on this change.

Change subject: hsm: deleteImage - lock image by imgUUID and sdUUID
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/28264/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 1465:         # vars.task.setDefaultException(se.ChangeMeError("%s" % args))
Line 1466:         pool = self.getPool(spUUID)
Line 1467:         dom = sdCache.produce(sdUUID=sdUUID)
Line 1468: 
Line 1469:         vars.task.getExclusiveLock(STORAGE, "%s_%s", imgUUID, sdUUID)
> making this change only here will remove the synchronization with other flo
from initial look seems that we need to smilar lock with the domain namespace as we do in other verbs like copyImage
                    rmanager.acquireResource(domainImageNamespace,
                                             ImgUUID, rm.LockType.exclusive)
Line 1470:         vars.task.getSharedLock(STORAGE, sdUUID)
Line 1471:         allVols = dom.getAllVolumes()
Line 1472:         volsByImg = sd.getVolsOfImage(allVols, imgUUID)
Line 1473:         if not volsByImg:


-- 
To view, visit http://gerrit.ovirt.org/28264
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I057b1f680276b1eb8a5d910260b7db4c4236fbf5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list