Change in vdsm[master]: replace configure_libvirt.py with python code.
ybronhei at redhat.com
ybronhei at redhat.com
Sun Jun 1 13:20:15 UTC 2014
Yaniv Bronhaim has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
......................................................................
Patch Set 21:
(2 comments)
http://gerrit.ovirt.org/#/c/27298/21/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:
Line 92:
Line 93: if utils.isOvirtNode():
Line 94: if not os.path.exists(P_VDSM_CERT):
Line 95: raise RuntimeError(
Line 96: "vdsm: Missing certificate, vdsm not registered")
raise InvalidRun instead, http://gerrit.ovirt.org/26565 was merged.
sorry to miss that last time
Line 97: validate_ovirt_certs.validate_ovirt_certs()
Line 98:
Line 99: # Remove a previous configuration (if present)
Line 100: self.removeConf()
Line 203: "reload-configuration"))
Line 204: if rc != 0:
Line 205: sys.stdout.write(out)
Line 206: sys.stderr.write(err)
Line 207: raise RuntimeError(
same
Line 208: "Failed to reload upstart configuration.")
Line 209:
Line 210: def _isSslConflict(self):
Line 211: """
--
To view, visit http://gerrit.ovirt.org/27298
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I74bfe05bb4b5f5d09021f21b324f9b7d5d0fdaab
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list