Change in vdsm[master]: get max_tasks and thread_pool_size from config by getint()

danken at redhat.com danken at redhat.com
Fri Jan 31 16:46:40 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: get max_tasks and thread_pool_size from config by getint()
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.ovirt.org/#/c/9035/4//COMMIT_MSG
Commit Message:

Line 10: 
Line 11: The max_tasks will be passed to the Queue as maxsize and the
Line 12: thread_pool_size is the thread number of the task thread pool.
Line 13: 
Line 14: So int is more reasonable than float
That is clearly true.
Line 15: 
Line 16: Additionally, create a new configuration variable
Line 17: mailbox_thread_pool_size so the number of threads assigned to the
Line 18: storage mailbox can be set independently.


Line 14: So int is more reasonable than float
Line 15: 
Line 16: Additionally, create a new configuration variable
Line 17: mailbox_thread_pool_size so the number of threads assigned to the
Line 18: storage mailbox can be set independently.
Why do we need additional configurables? I know it's an ancient commit but it should have been splitted.
Line 19: 
Line 20: Change-Id: I9fc719b1b4238b0df2d9c882777cb75d7a27d4df
Line 21: Signed-off-by: ShaoHe Feng <shaohef at linux.vnet.ibm.com>


-- 
To view, visit http://gerrit.ovirt.org/9035
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9fc719b1b4238b0df2d9c882777cb75d7a27d4df
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Hunt Xu <mhuntxu at gmail.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list