Change in vdsm[master]: sos: plugin should ignore /var/run/vdsm/storage

danken at redhat.com danken at redhat.com
Fri Jan 31 11:44:03 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: sos: plugin should ignore /var/run/vdsm/storage
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/23925/2/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:

Line 120:         import glob
Line 121: 
Line 122:         for f in glob.glob("@VDSMRUNDIR@/*"):
Line 123:             if not f.endswith('.vfd') and not f.endswith('/isoUploader') \
Line 124:                     and not f.endswith('/storage'):
> but you're doing 3 function calls and one test for each file... not really 
Efficiency of the log collector is determined by the size of the log files, not another string comparison per /var/run/vdsm/* file.

I prefer the current code since it better reflects what we want to collect: we'd like to take EVERYTHING from /var/run/vdsm EXCEPT a couple of too heavy files.


-- 
To view, visit http://gerrit.ovirt.org/23925
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie60d681cc744f2407a0ddf9406225e73497ac648
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list