Change in vdsm[master]: vm: do not build domain xml when recovering state

fromani at redhat.com fromani at redhat.com
Thu Jan 30 17:39:26 UTC 2014


Francesco Romani has uploaded a new change for review.

Change subject: vm: do not build domain xml when recovering state
......................................................................

vm: do not build domain xml when recovering state

as discussed during the review of
http://gerrit.ovirt.org/#/c/23915
in the restoring state code path the VM domain XML si built and
the before_vm_start hook is called, but not the after_vm_start
one.

Moreover, the recover state path doesn't seem to have any
direct dependency on the xml built.

Those two steps seems useless, so this patch drops them.

Change-Id: Ifd9dd2cb49910d77327aae0d07dc562399fc9d5b
Signed-off-by: Francesco Romani <fromani at redhat.com>
---
M vdsm/vm.py
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/23/23923/1

diff --git a/vdsm/vm.py b/vdsm/vm.py
index 0f42784..4914653 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -3134,9 +3134,6 @@
             # Reinitialize the merge statuses
             self._checkMerge()
         elif 'restoreState' in self.conf:
-            domxml = hooks.before_vm_start(self._buildCmdLine(), self.conf)
-            self.log.debug(domxml)
-
             fromSnapshot = self.conf.get('restoreFromSnapshot', False)
             srcDomXML = self.conf.pop('_srcDomXML')
             if fromSnapshot:


-- 
To view, visit http://gerrit.ovirt.org/23923
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd9dd2cb49910d77327aae0d07dc562399fc9d5b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>


More information about the vdsm-patches mailing list