Change in vdsm[master]: vm: janitorial: simply the recovering flow

fromani at redhat.com fromani at redhat.com
Thu Jan 30 16:32:03 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: vm: janitorial: simply the recovering flow
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/23915/1/vdsm/vm.py
File vdsm/vm.py:

Line 3157: before_vm_start
> Moving this here, changes the semantics. It's not called when it's restorin
Agreed. I do have a question however (not to argue but to achieve a better understanding). The original code called those two lines also in the restore state pathm but:

* the domxml object returned is never used directly; do we rely here on a side effect of buildCmdLine, side effect which has to be  reserved?
* the before_vm_start hook is called, but not the after_vm_start one.

Is this really the intended behaviour or there is a bug lurking here?


-- 
To view, visit http://gerrit.ovirt.org/23915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2c1bc48b9f4df7cb236f27c44755d9778e7e6c9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list