Change in vdsm[master]: Moving response implementation of getAllVmStats to API.py

danken at redhat.com danken at redhat.com
Thu Jan 30 15:32:25 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Moving response implementation of getAllVmStats to API.py
......................................................................


Moving response implementation of getAllVmStats to API.py

This code was introduced as part of jsonrpc work.

getAllVmStats command was implemented in xml binding whereas it should
be in API. Xml binging uses API directly and json binding uses bridge to
proxy calls to API. Having this logic in API instead of xml binging
makes it available for both protocols.

Change-Id: Ic86f5daf5def88ea4fecad85cf2b1aa5a919cc39
Signed-off-by: pkliczewski <piotr.kliczewski at gmail.com>
Reviewed-on: http://gerrit.ovirt.org/23376
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-by: Adam Litke <alitke at redhat.com>
---
M vdsm/API.py
M vdsm/BindingXMLRPC.py
2 files changed, 14 insertions(+), 10 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Adam Litke: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/23376
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic86f5daf5def88ea4fecad85cf2b1aa5a919cc39
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list