Change in vdsm[ovirt-3.4]: netconfig: set ETHTOOL_OPTS when a NIC goes up

ybronhei at redhat.com ybronhei at redhat.com
Thu Jan 30 15:22:22 UTC 2014


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: netconfig: set ETHTOOL_OPTS when a NIC goes up
......................................................................


netconfig: set ETHTOOL_OPTS when a NIC goes up

There's broken hardware out there where lro needs to to be turned off
explicitly.
This patch lets an admin of a local node set

  ethtool_opts.eth0 = lro off

to disable LRO on the interface named eth0.

This patch includes a substantial fix based on
Iac6646bbad8c7431ec1c035ebc01f0180a8338ee by Antoni S. Puimedon.

Bug-Url: https://bugzilla.redhat.com/1059680
Change-Id: Ic8a5a933e1c93f80185d61f3cd43eee53c3a7c1a
Signed-off-by: Antoni S. Puimedon <asegurap at redhat.com>
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/23366
Reviewed-on: http://gerrit.ovirt.org/23792
Reviewed-on: http://gerrit.ovirt.org/23761
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M lib/vdsm/config.py.in
M vdsm/netconf/__init__.py
M vdsm/netconf/ifcfg.py
M vdsm/netconf/iproute2.py
4 files changed, 37 insertions(+), 2 deletions(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, approved
  Antoni Segura Puimedon: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/23761
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic8a5a933e1c93f80185d61f3cd43eee53c3a7c1a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list