Change in vdsm[master]: gluster: Fix vdsm-tool crash report detected by abrt

Alon Bar-Lev alonbl at redhat.com
Thu Jan 30 11:48:05 UTC 2014


Alon Bar-Lev has posted comments on this change.

Change subject: gluster: Fix vdsm-tool crash report detected by abrt
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/23551/1/lib/vdsm/tool/vdsm-id.py
File lib/vdsm/tool/vdsm-id.py:

Line 29:     """
Line 30:     hostUUID = getHostUUID(False)
Line 31:     if hostUUID is None:
Line 32:         sys.stderr.write('Cannot retrieve host UUID\n')
Line 33:         return 1
> Can we alternatively ask abrt not to consider vdsm-tool exceptions as "cras
we can, but it is out of scope of this project.

exception that is not handled by code is considered 'unhandled', thus programmer error.

we had this discussion long ago. a tool should be at our full control, it should not relay on python to perform the abnormal termination.

See discussion at [1], May 21 and on.

[1] http://gerrit.ovirt.org/#/c/14866/
Line 34:     sys.stdout.write(hostUUID)


-- 
To view, visit http://gerrit.ovirt.org/23551
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c7b677ef8de713d2912f8926991b1dcd8134ccf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list