Change in vdsm[master]: guest: Add support for guest cpu topology

vfeenstr at redhat.com vfeenstr at redhat.com
Tue Jan 28 12:24:29 UTC 2014


Vinzenz Feenstra has posted comments on this change.

Change subject: guest: Add support for guest cpu topology
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.ovirt.org/#/c/23258/8/vdsm/guestIF.py
File vdsm/guestIF.py:

Line 301:                 # Converting to string because XML-RPC doesn't support 64-bit
Line 302:                 # integers.
Line 303:                 disk['total'] = str(disk['total'])
Line 304:                 disk['used'] = str(disk['used'])
Line 305:                 disks.append(disk)
> general thing - couldn't we replace this tired long methods with some dispa
Well not really part of this patch. But also danken said that already, and I was suggestiong a rewrite for that also already
Line 306:             self.guestInfo['disksUsage'] = disks
Line 307:         elif message == 'cpu-topology':
Line 308:             API_VALUES = ('threads', 'sockets', 'cores', 'online', 'offline',
Line 309:                           'possible', 'present')


-- 
To view, visit http://gerrit.ovirt.org/23258
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I827ab095ee9270faf27f44e91c7bc998e133351e
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list