Change in vdsm[ovirt-3.4]: vdsm.spec: own metadata supervdsm mom logs

dougsland at redhat.com dougsland at redhat.com
Tue Jan 28 01:03:35 UTC 2014


Hello Dan Kenigsberg,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/23786

to review the following change.

Change subject: vdsm.spec: own metadata supervdsm mom logs
......................................................................

vdsm.spec: own metadata supervdsm mom logs

/var/log/vdsm/metadata.log /var/log/vdsm/supervdsm.log
/var/log/vdsm/mom.log should be owned by VDSM.

Additionaly, now are now creating with touch those files
(and vdsm.log) during the vdsm rpm install.

Change-Id: I2776b8518930393b281a1885268813f8d4d7c85b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1055153
Signed-off-by: Douglas Schilling Landgraf <dougsland at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/23754
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm.spec.in
1 file changed, 8 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/23786/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 697c571..a5cab66 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -610,9 +610,11 @@
 rm -rf %{buildroot}
 make DESTDIR=%{buildroot} install
 
-# VDSM Log
+# Creating VDSM logs
 install -dDm 0755 %{buildroot}@VDSMLOGDIR@
-# Avoid rpmbuild complain about vdsm.log doesn't exist during the build
+touch %{buildroot}@VDSMLOGDIR@/metadata.log
+touch %{buildroot}@VDSMLOGDIR@/mom.log
+touch %{buildroot}@VDSMLOGDIR@/supervdsm.log
 touch %{buildroot}@VDSMLOGDIR@/vdsm.log
 
 # Install the respawn utility
@@ -879,7 +881,10 @@
 %endif
 
 %dir %attr(-, %{vdsm_user}, %{vdsm_group}) @vdsmrepo@
-%ghost %config %attr(0644, %{vdsm_user}, %{vdsm_group}) @VDSMLOGDIR@/vdsm.log
+%config %attr(0644, %{vdsm_user}, %{vdsm_group}) @VDSMLOGDIR@/metadata.log
+%config %attr(0644, %{vdsm_user}, %{vdsm_group}) @VDSMLOGDIR@/mom.log
+%config %attr(0644, root, root) @VDSMLOGDIR@/supervdsm.log
+%config %attr(0644, %{vdsm_user}, %{vdsm_group}) @VDSMLOGDIR@/vdsm.log
 %ghost %dir %attr(-, %{vdsm_user}, %{vdsm_group}) @vdsmrepo@/hsm-tasks
 %ghost %dir %attr(-, %{vdsm_user}, %{vdsm_group}) @vdsmrepo@/mnt
 %dir %{_libexecdir}/%{vdsm_name}


-- 
To view, visit http://gerrit.ovirt.org/23786
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2776b8518930393b281a1885268813f8d4d7c85b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list