Change in vdsm[master]: vdsm.spec: own metadata supervdsm mom logs

dougsland at redhat.com dougsland at redhat.com
Mon Jan 27 20:02:00 UTC 2014


Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm.spec: own metadata supervdsm mom logs
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.ovirt.org/#/c/23754/1/vdsm.spec.in
File vdsm.spec.in:

Line 614: # VDSM Log
Line 615: install -dDm 0755 %{buildroot}@VDSMLOGDIR@
Line 616: # Avoid rpmbuild complain about files that doesn't exist during the build
Line 617: touch %{buildroot}@VDSMLOGDIR@/metadata.log
Line 618: touch %{buildroot}@VDSMLOGDIR@/supervdsm.log
> We would like to change the fact that they are not installed.
Ok, looks like a separate patch for make install right?
Line 619: touch %{buildroot}@VDSMLOGDIR@/vdsm.log
Line 620: 
Line 621: # Install the respawn utility
Line 622: install -Dm 0755 init/sysvinit/respawn \


Line 882: %endif
Line 883: 
Line 884: %dir %attr(-, %{vdsm_user}, %{vdsm_group}) @vdsmrepo@
Line 885: %ghost %config %attr(0644, %{vdsm_user}, %{vdsm_group}) @VDSMLOGDIR@/metadata.log
Line 886: %ghost %config %attr(0644, %{vdsm_user}, %{vdsm_group}) @VDSMLOGDIR@/supervdsm.log
> Yes, but it is a bit disturbing to see
ah, make sense. Just changing 0,0 to root since rpmbuild doesn't know about 0,0. The next version of this patch will create the log files during the rpm install (removing the %ghost macro) but if any other process write there without specifying user/group (as root for example) will keep this failure. I still working on a reproducer.
Line 887: %ghost %config %attr(0644, %{vdsm_user}, %{vdsm_group}) @VDSMLOGDIR@/vdsm.log
Line 888: %ghost %dir %attr(-, %{vdsm_user}, %{vdsm_group}) @vdsmrepo@/hsm-tasks
Line 889: %ghost %dir %attr(-, %{vdsm_user}, %{vdsm_group}) @vdsmrepo@/mnt
Line 890: %dir %{_libexecdir}/%{vdsm_name}


-- 
To view, visit http://gerrit.ovirt.org/23754
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2776b8518930393b281a1885268813f8d4d7c85b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list