Change in vdsm[master]: Using execCmd to run dmidecode command instead of using subp...

danken at redhat.com danken at redhat.com
Sun Jan 26 22:30:22 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Using execCmd to run dmidecode command instead of using subprocess.Popen
......................................................................


Using execCmd to run dmidecode command instead of using subprocess.Popen

This change is due to a bug while running 'vdsm-tool vdsm-id' as user
root which calls this function and fails on "require tty" for user root.

execCmd skip the sudo=True parameter while executing the command [1]

[1] http://gerrit.ovirt.org/#/c/23721/

Change-Id: I28f4aad240711a2ab4339c7551aa1d88913f735b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1054759
Signed-off-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/23722
Reviewed-by: Alon Bar-Lev <alonbl at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/utils.py
1 file changed, 6 insertions(+), 8 deletions(-)

Approvals:
  Alon Bar-Lev: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/23722
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I28f4aad240711a2ab4339c7551aa1d88913f735b
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list