Change in vdsm[master]: Using execCmd to run dmidecode command instead of using subp...
Alon Bar-Lev
alonbl at redhat.com
Sun Jan 26 16:00:43 UTC 2014
Alon Bar-Lev has posted comments on this change.
Change subject: Using execCmd to run dmidecode command instead of using subprocess.Popen
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.ovirt.org/#/c/23722/3/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 691: if arch in ('x86_64', 'i686'):
Line 692: ret, out, err = execCmd([constants.EXT_DMIDECODE, "-s",
Line 693: "system-uuid"],
Line 694: sudo=True)
Line 695: if ret == 0 and 'Not' not in out:
'\n'.join(out) ?
Line 696: #Avoid error string - 'Not Settable' or 'Not Present'
Line 697: __hostUUID = out[0].strip()
Line 698: else:
Line 699: logging.warning('Could not find host UUID: %s', err)
Line 695: if ret == 0 and 'Not' not in out:
Line 696: #Avoid error string - 'Not Settable' or 'Not Present'
Line 697: __hostUUID = out[0].strip()
Line 698: else:
Line 699: logging.warning('Could not find host UUID: %s', err)
please do not change more than patch intended.
Line 700: elif arch in ('ppc', 'ppc64'):
Line 701: #eg. output IBM,03061C14A
Line 702: try:
Line 703: with open('/proc/device-tree/system-id') as f:
--
To view, visit http://gerrit.ovirt.org/23722
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I28f4aad240711a2ab4339c7551aa1d88913f735b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list