Change in vdsm[master]: vdsm.spec: replace if ! 0%{?with_systemd}

ybronhei at redhat.com ybronhei at redhat.com
Sun Jan 26 12:00:03 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm.spec: replace if ! 0%{?with_systemd}
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/23603/1/vdsm.spec.in
File vdsm.spec.in:

Line 35: 
Line 36: %if 0%{?fedora} >= 15 || 0%{?rhel} >= 7
Line 37: %global with_systemd 1
Line 38: %else
Line 39: %global with_sysv 1
> Hi Dan,  I thought this if was enough clear to define which system is runni
dan only suggested to have only one verb (with_sysv or with_systemd) so it'll be obvious that its either with one of the systems or not, otherwise you can set both to 0 which is wrong.
so he suggested to replace with_systemd to with_sysv and change the entire contact accordingly to avoid many NOTs 

but it'll be the same.. all with_systemd will turn to ! with_sysv
Line 40: %endif
Line 41: 
Line 42: %if 0%{?fedora} >= 18
Line 43: %global with_systemd_macros 1


-- 
To view, visit http://gerrit.ovirt.org/23603
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I55a104a7ec6ed7ea57803157e9d62334a26caf7c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list