Change in vdsm[master]: vdsm.spec: vdsm should own vdsm.log

danken at redhat.com danken at redhat.com
Sat Jan 25 11:16:46 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm.spec: vdsm should own vdsm.log
......................................................................


Patch Set 5: Code-Review-1

(2 comments)

http://gerrit.ovirt.org/#/c/23696/5/vdsm.spec.in
File vdsm.spec.in:

Line 613: 
Line 614: # VDSM Log
Line 615: install -dDm 0755 %{buildroot}@VDSMLOGDIR@
Line 616: # Avoid rpmbuild complain about vdsm.log doesn't exist during the build
Line 617: touch %{buildroot}@VDSMLOGDIR@/%{vdsm_name}.log
Please see logger.conf: the file name is independently of %vdsm_name.
Line 618: 
Line 619: # Install the respawn utility
Line 620: install -Dm 0755 init/sysvinit/respawn \
Line 621:                  %{buildroot}%{_datadir}/%{vdsm_name}/respawn


Line 914: %{_datadir}/%{vdsm_name}/vdsm-restore-net-config
Line 915: %{_datadir}/%{vdsm_name}/vdsm-store-net-config
Line 916: %{_datadir}/%{vdsm_name}/vm.py*
Line 917: 
Line 918: %ghost %config %attr(0644, %{vdsm_user}, %{vdsm_group}) @VDSMLOGDIR@/%{vdsm_name}.log
Any way to shorten this line?
Line 919: 
Line 920: %config(noreplace) %{_sysconfdir}/%{vdsm_name}/logger.conf
Line 921: %config(noreplace) %{_sysconfdir}/%{vdsm_name}/svdsm.logger.conf
Line 922: %config(noreplace) %{_sysconfdir}/%{vdsm_name}/upgrade.logger.conf


-- 
To view, visit http://gerrit.ovirt.org/23696
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id12a78f3243138cd95a13cc7c8a8d3d499ceee4a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list