Change in vdsm[ovirt-3.3]: vdsm hooks: this patch provides after/before_network_setup h...
majopela at redhat.com
majopela at redhat.com
Fri Jan 24 10:53:56 UTC 2014
Miguel Angel Ajo Pelayo has posted comments on this change.
Change subject: vdsm hooks: this patch provides after/before_network_setup hooks.
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/23659/1/tests/hookValidation.py
File tests/hookValidation.py:
Line 73: kwargs['hook_cookiefile'] = cookie_file
Line 74: output = test_function(*args, **kwargs)
Line 75: finally:
Line 76: if directory_existed:
Line 77: os.unlink(cookie_file)
I believe we made a second patch on top of this one, to fix
test hook files being left around.
I believe we should backport it too, although it only affected the testing, not production environments.
Line 78: else:
Line 79: shutil.rmtree(hook_path)
Line 80:
Line 81: if not functional:
--
To view, visit http://gerrit.ovirt.org/23659
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac5c6f57b300b3b1a2a9bfad4a7919f4d8a74707
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Miguel Angel Ajo Pelayo <majopela at redhat.com>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list