Change in vdsm[master]: gluster: Fix vdsm-tool crash report detected by abrt

Alon Bar-Lev alonbl at redhat.com
Fri Jan 24 08:52:45 UTC 2014


Alon Bar-Lev has posted comments on this change.

Change subject: gluster: Fix vdsm-tool crash report detected by abrt
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

http://gerrit.ovirt.org/#/c/23551/1//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-01-22 15:50:32 +0530
Line 4: Commit:     Timothy Asir <tjeyasin at redhat.com>
Line 5: CommitDate: 2014-01-22 16:18:40 +0530
Line 6: 
Line 7: gluster: Fix vdsm-tool crash report detected by abrt
it is not gluster
Line 8: 
Line 9: During bootstrap 'vdsm-tool vdsm-id' command exits with runtime error
Line 10: if no host uuid is found. This causes abrt demon to detect it as a
Line 11: crash and report to mail system.


http://gerrit.ovirt.org/#/c/23551/1/lib/vdsm/tool/vdsm-id.py
File lib/vdsm/tool/vdsm-id.py:

Line 29:     """
Line 30:     hostUUID = getHostUUID(False)
Line 31:     if hostUUID is None:
Line 32:         sys.stderr.write('Cannot retrieve host UUID\n')
Line 33:         return 1
this should be in global scope of vdsm-tool, as the issue does not apply to this specific command.
Line 34:     sys.stdout.write(hostUUID)


-- 
To view, visit http://gerrit.ovirt.org/23551
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c7b677ef8de713d2912f8926991b1dcd8134ccf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list