Change in vdsm[master]: sysvinit: Ensure that iscsid is started

danken at redhat.com danken at redhat.com
Thu Jan 23 11:06:28 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: sysvinit: Ensure that iscsid is started
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.ovirt.org/#/c/23601/3//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: sysvinit: Ensure that iscsid is started
Line 8: 
Line 9: Since commit 3c0adf791e, we start iscsid service using the "start"
Line 10: command like other services. This works fine the iscsi.startup option is
works fine *when* the iscsi.startup
Line 11: configured in /etc/iscsi/iscsi.conf, and this seem to be common on our
Line 12: machines. However if the configuration is missing, we must start iscsid
Line 13: using the "force-start" command.
Line 14: 


Line 12: machines. However if the configuration is missing, we must start iscsid
Line 13: using the "force-start" command.
Line 14: 
Line 15: Commit 3c0adf791e suggests that "force-start" is not supported. Testing
Line 16: show that not only this option is supported, it is required to start
if I understand correctly, it is required if someone removes iscsi.startup=automatic from /etc/iscsi/iscsi.conf.

I believe that 3c0adf791e was mislead by "force-start" removal from systemd.
Line 17: iscsid, because we set node.startup option to "manual", and iscsid
Line 18: "start" may sliently not start in this case.
Line 19: 
Line 20: This patch fixes the startup on sysvinit by starting iscsid using


-- 
To view, visit http://gerrit.ovirt.org/23601
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb5c3de4f8dccb1d8344182d5016feabcf86a7df
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list