Change in vdsm[master]: sysvinit: Ensure that iscsid is started

Alon Bar-Lev alonbl at redhat.com
Wed Jan 22 18:48:11 UTC 2014


Alon Bar-Lev has posted comments on this change.

Change subject: sysvinit: Ensure that iscsid is started
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/23601/1/init/sysvinit/vdsmd.init.in
File init/sysvinit/vdsmd.init.in:

Line 86:                     service "${srv}" force-start
Line 87:                 else
Line 88:                     service "${srv}" start
Line 89:                 fi
Line 90:             fi
> Makes sense, this is bit ugly here. Where do you suggest to put the iscsid 
instead of having specific code within generic loop, just add a block for iscsid

 -needed_services=".... iscsid ..."
 +needed_services="...."

 +service iscsid status > /dev/null 2>&1 || service iscsid force-start

that's the entire change you need, 2 lines.

another option which is more complex but will fall into generic is to modify needed_services to have the following format:

 service[(start-argument)]]

then when looping extract the optional start argument and use it if exists. but for one exception it is not worth it.
Line 91:         fi
Line 92:         ret_val=$?
Line 93:         if [ "${ret_val}" -ne 0 ]; then
Line 94:             log_failure_msg "${prog}: Start dependent ${srv}"


-- 
To view, visit http://gerrit.ovirt.org/23601
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb5c3de4f8dccb1d8344182d5016feabcf86a7df
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list