Change in vdsm[master]: gluster: enhance vdsmcli error handling

danken at redhat.com danken at redhat.com
Wed Jan 22 07:40:38 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: gluster: enhance vdsmcli error handling
......................................................................


gluster: enhance vdsmcli error handling

Vdsmcli also treated as a functional testing tool. Checking
the functional parameter could hide the state of depending
function. Engine might call those functions without these
parameters also. So the parameter null check should go inside
the gluster function.

Change-Id: I2e29dfb724cf4c8370bf836d64510376df37058a
Signed-off-by: Timothy Asir <tjeyasin at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/23057
Reviewed-by: Bala.FA <barumuga at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M client/vdsClientGluster.py
1 file changed, 9 insertions(+), 42 deletions(-)

Approvals:
  Timothy Asir: Verified
  Bala.FA: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/23057
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2e29dfb724cf4c8370bf836d64510376df37058a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Humble Devassy Chirammal <hchiramm at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list