Change in vdsm[master]: netinfo: optimize ipaddr retrieval

asegurap at redhat.com asegurap at redhat.com
Tue Jan 21 16:21:19 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: netinfo: optimize ipaddr retrieval
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/23518/1//COMMIT_MSG
Commit Message:

Line 22: retrieve all the ipaddrs and then we match them to the devices
Line 23: we have, saving most of the work.
Line 24: 
Line 25: = 603 calls to getIpInfo for 0.009371s (0.03327s spent on vdsm.netlink from
Line 26: netinfo.get)
> How can we spend 0.03327s in vdsm.netlink if the whole process took only 0.
With this patch the netlink part happens outside of getIpInfo, so I added it in parenthesis noting that it is inside netinfo.get. I guess it could have been misunderstood :P
Line 27: 
Line 28: Change-Id: I571529f6dd379ffb317625fd9e2abd6b5ae88696


-- 
To view, visit http://gerrit.ovirt.org/23518
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I571529f6dd379ffb317625fd9e2abd6b5ae88696
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list