Change in vdsm[master]: To allow downgrade of vdsm we need to support vdsm-tool old API

dougsland at redhat.com dougsland at redhat.com
Mon Jan 20 15:49:27 UTC 2014


Douglas Schilling Landgraf has posted comments on this change.

Change subject: To allow downgrade of vdsm we need to support vdsm-tool old API
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

http://gerrit.ovirt.org/#/c/23333/2/vdsm.spec.in
File vdsm.spec.in:

Line 696: fi
Line 697: /sbin/restorecon -R /var/log/core >/dev/null 2>&1
Line 698: # hack until we replace core dump with abrt
Line 699: 
Line 700: %if ! 0%{?with_systemd}
> I preferred having the minimal change in 23235, to avoid inadvertent errors
I am ok to change for positive question, new patch soon... (not related with this one)
Line 701: if [ "$1" -eq 1 ] ; then
Line 702:     /sbin/chkconfig --add vdsmd
Line 703:     /sbin/chkconfig --add supervdsmd
Line 704: fi


Line 808:     fi
Line 809: fi
Line 810: exit 0
Line 811: 
Line 812: %if 0%{?rhel} == 6
> it should be based on explicit feature like systemd or sysv not based on ve
I do believe it's safe to make it based on sysv. I will send a patch here too.
Line 813: # In el6, We configure libvirt to use upstart without the libvirt.rpm's
Line 814: # awareness. Thus, we must stop/restart libvirt ourselves when the
Line 815: # libvirt.rpm is removed/upgraded.
Line 816: %triggerun -- libvirt


-- 
To view, visit http://gerrit.ovirt.org/23333
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bd7f9048acc4f53f3da66e21d5ad2c5caf2a5ad
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list