Change in vdsm[master]: MonkeyPatch: fix reverting staticmethods.

asegurap at redhat.com asegurap at redhat.com
Mon Jan 20 14:57:29 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: MonkeyPatch: fix reverting staticmethods.
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/23378/2/tests/monkeypatch.py
File tests/monkeypatch.py:

Line 74:             if type(that) != type(getattr(module, name)):
Line 75:                 if isinstance(that, types.FunctionType):
Line 76:                     setattr(module, name, staticmethod(that))
Line 77: 
Line 78: 
> Unfortunately our code is broken not only when reverting by when applying p
Done
Line 79: #
Line 80: # Monkey patch scope.
Line 81: #
Line 82: # Usage:


-- 
To view, visit http://gerrit.ovirt.org/23378
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3100455ab761481f57a93ab8aacc34ac4ab91eb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list