Change in vdsm[master]: dump the core of a VM

jmoskovc at redhat.com jmoskovc at redhat.com
Mon Jan 20 13:22:15 UTC 2014


Jiří Moskovčák has posted comments on this change.

Change subject: dump the core of a VM
......................................................................


Patch Set 16: Code-Review-1

(1 comment)

Just a minor thing, but I'd rather see it fixed, so it won't hit as later. The rest looks ok.

http://gerrit.ovirt.org/#/c/7329/16/vdsm/vm.py
File vdsm/vm.py:

Line 494:                 self.status = {'code': CoreDumpThread.Status.CANCELED,
Line 495:                                'message': 'The operation has been aborted'}
Line 496:             else:
Line 497:                 self.status = reportError(msg=e.message)
Line 498:         except Exception, e:
please use "<ExceptionType> as e" everywhere
Line 499:             self.status = reportError(msg=e.message)
Line 500: 
Line 501: 
Line 502: class VolumeError(RuntimeError):


-- 
To view, visit http://gerrit.ovirt.org/7329
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If4aac9e747dc7aa64a6ff5ef256a7a4375aa2bb5
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list