Change in vdsm[master]: BindingXMLRPC and API refactoring

ybronhei at redhat.com ybronhei at redhat.com
Mon Jan 20 13:18:43 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: BindingXMLRPC and API refactoring
......................................................................


Patch Set 1:

:) it does kind of refactoring.. but you know, put it as a title - "BindingXMLRPC and API refactoring" implies that you do here much more than just moving part of code from here to there.. I'm just suggesting that it might be a wrong title for this kind of change, "moving code from here to there because yadayada" is much better to understand what to suspect from that patch than "refactoring" in my opinion

-- 
To view, visit http://gerrit.ovirt.org/23376
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic86f5daf5def88ea4fecad85cf2b1aa5a919cc39
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list