Change in vdsm[master]: tests: add missing attribute in LibvirtMock object

danken at redhat.com danken at redhat.com
Mon Jan 20 09:34:06 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: tests: add missing attribute in LibvirtMock object
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

http://gerrit.ovirt.org/#/c/23374/1//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2014-01-17 09:44:57 +0100
Line 6: 
Line 7: tests: add missing attribute in LibvirtMock object
Line 8: 
Line 9: libvirtconnectionTests used to deliver an attribute error
sorry, I do not understand when this is delivered (and *I* have not seen it).
Line 10: because the LibvirtMock was incomplete, lacking the
Line 11: 'virEventRunDefaultImpl' attribute.
Line 12: 
Line 13: This patch add the missing attribute.


Line 9: libvirtconnectionTests used to deliver an attribute error
Line 10: because the LibvirtMock was incomplete, lacking the
Line 11: 'virEventRunDefaultImpl' attribute.
Line 12: 
Line 13: This patch add the missing attribute.
add -> adds
Line 14: 
Line 15: Change-Id: I4e8f14aafd4561b35b6987a8524f62b91aea50d8


-- 
To view, visit http://gerrit.ovirt.org/23374
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e8f14aafd4561b35b6987a8524f62b91aea50d8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list