Change in vdsm[master]: guest: Add support for guest cpu topology

fromani at redhat.com fromani at redhat.com
Fri Jan 17 15:24:45 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: guest: Add support for guest cpu topology
......................................................................


Patch Set 7:

(2 comments)

http://gerrit.ovirt.org/#/c/23258/7/vdsm/guestIF.py
File vdsm/guestIF.py:

Line 313: ]
I was wondering if

  topology = dict((name, args[name]) for name in API_VALUES if name in args)

is any better (it should be py2.6 friendly)


Line 394: :
Any chance to narrow this?


-- 
To view, visit http://gerrit.ovirt.org/23258
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I827ab095ee9270faf27f44e91c7bc998e133351e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list