Change in vdsm[master]: gluster: additional parsing of host UUID in verb glusterVolu...

dnarayan at redhat.com dnarayan at redhat.com
Fri Jan 17 14:18:05 UTC 2014


Darshan N has posted comments on this change.

Change subject: gluster: additional parsing of host UUID in verb glusterVolumesList
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/22693/4/vdsm/gluster/cli.py
File vdsm/gluster/cli.py:

Line 360:             value['bricks'].append(b.text)
Line 361:         for o in el.findall('options/option'):
Line 362:             value['options'][o.find('name').text] = o.find('value').text
Line 363:         for d in el.findall('bricks/brick'):
Line 364:             brickDetail = {}
> Can this be added only if hostUuid is found in the xml?
Done
Line 365:             brickDetail['name'] = d.find('name').text
Line 366:             brickDetail['hostUuid'] = d.find('hostUuid').text
Line 367:             value['bricksInfo'].append(brickDetail)
Line 368:         volumes[value['volumeName']] = value


-- 
To view, visit http://gerrit.ovirt.org/22693
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9057f3aea0c0ed8fb4d4ec26eaf66fe80ec581e2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list