Change in vdsm[master]: ipwrapper: make Link's _detectType module level

danken at redhat.com danken at redhat.com
Thu Jan 16 16:35:11 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: ipwrapper: make Link's _detectType module level
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/23365/3//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-01-16 16:53:12 +0100
Line 4: Commit:     Antoni S. Puimedon <asegurap at redhat.com>
Line 5: CommitDate: 2014-01-16 17:04:08 +0100
Line 6: 
Line 7: ipwrapper: make Link's _detectType module level
could  you explain why this is a good thing? I failed to reproduce the @classmethod issue you spoke about over irc.
Line 8: 
Line 9: Change-Id: I0c7c5cf4a6e7b5a78500bb7a40fd105f0e310dbe


-- 
To view, visit http://gerrit.ovirt.org/23365
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0c7c5cf4a6e7b5a78500bb7a40fd105f0e310dbe
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list