Change in vdsm[master]: Extend setupNetworks API to accept defaultRoute

amuller at redhat.com amuller at redhat.com
Thu Jan 16 13:45:30 UTC 2014


Assaf Muller has posted comments on this change.

Change subject: Extend setupNetworks API to accept defaultRoute
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/22720/2/vdsm/configNetwork.py
File vdsm/configNetwork.py:

Line 249:     # the management network.
Line 250:     # TODO: When oVirt 3.3 is deprecated, change the default to False and
Line 251:     #       remove reference to constants.MANAGEMENT_NETWORKS
Line 252:     if defaultRoute is None:
Line 253:         defaultRoute = network in constants.MANAGEMENT_NETWORKS
> needs renaming to LEGACY_MANAGEMENT_NETWORKS
Oh I didn't rebase yet.
Line 254: 
Line 255:     logging.info("Adding network %s with vlan=%s, bonding=%s, nics=%s,"
Line 256:                  " bondingOptions=%s, mtu=%s, bridged=%s, defaultRoute=%s,"
Line 257:                  "options=%s", network, vlan, bonding, nics, bondingOptions,


-- 
To view, visit http://gerrit.ovirt.org/22720
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b2ff711155eb0bd79ab84e979eb82c846362374
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list