Change in vdsm[master]: Changing vdsm-tool and vdsmd pre-tasks outputs to be more me...
vvolansk at redhat.com
vvolansk at redhat.com
Thu Jan 16 13:25:22 UTC 2014
Vered Volansky has posted comments on this change.
Change subject: Changing vdsm-tool and vdsmd pre-tasks outputs to be more meaningful to user
......................................................................
Patch Set 1: Verified+1 Code-Review+1
(3 comments)
*Great* patch. Usage is soooooo much better now.
http://gerrit.ovirt.org/#/c/23253/1//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2014-01-14 18:09:31 +0200
Line 6:
Line 7: Changing vdsm-tool and vdsmd pre-tasks outputs to be more meaningful to user
Line 8:
Line 9: Previously to this changes the output was misleading. Users
/this/these
Line 10: could not understand how to handle configuration issues properly.
Line 11:
Line 12: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1029812
Line 13: Change-Id: If29f41081a70c0734cd78dab36f86c794a44b2d3
http://gerrit.ovirt.org/#/c/23253/1/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:
Line 247:
Line 248: if not ret:
Line 249: msg = \
Line 250: """
Line 251:
Is there a redundant empty line here or is it just gerrit?
Line 252: One of the modules is not configured to VDSM.
Line 253: To configure the module use the following:
Line 254: 'vdsm-tool configure [module_name]'.
Line 255:
Line 248: if not ret:
Line 249: msg = \
Line 250: """
Line 251:
Line 252: One of the modules is not configured to VDSM.
/to/with
Line 253: To configure the module use the following:
Line 254: 'vdsm-tool configure [module_name]'.
Line 255:
Line 256: If all modules are not configured try to use:
--
To view, visit http://gerrit.ovirt.org/23253
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If29f41081a70c0734cd78dab36f86c794a44b2d3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list