Change in vdsm[master]: netinfo: ifcfg: ignore 0 suffix

danken at redhat.com danken at redhat.com
Thu Jan 16 12:12:23 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: netinfo: ifcfg: ignore 0 suffix
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/23329/1//COMMIT_MSG
Commit Message:

> Doesn't IPADDR1 mean configuring a second IP address, IPADDR2 a third, and 
Yes, IPADDR1 means a second IP address for the device (which we do not support).

If an ifcfg file has  IPADDR and IPADDR0, just as if it has IPADDR twice, the second occurrence takes effect.

I agree that we should delve as little as possible into ifcfg* parsing.
Line 1: Parent:     54cc6747 (vdsm: Replaced all too generic except: handlers in vm.py)
Line 2: Author:     Dan Kenigsberg <danken at redhat.com>
Line 3: AuthorDate: 2014-01-16 11:51:06 +0000
Line 4: Commit:     Dan Kenigsberg <danken at redhat.com>


-- 
To view, visit http://gerrit.ovirt.org/23329
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c9a206a5b96d0b38aab9c3d62d6074424b419be
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list