Change in vdsm[master]: securable: refactor the securable implementation

nsoffer at redhat.com nsoffer at redhat.com
Thu Jan 16 11:49:53 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: securable: refactor the securable implementation
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.ovirt.org/#/c/22115/6/vdsm/storage/securable.py
File vdsm/storage/securable.py:

Line 21: from functools import wraps
Line 22: 
Line 23: OVERRIDE_ARG = "__securityOverride"
Line 24: SECURE_FIELD = "__secured__"
Line 25: SECURE_METHOD_NAME = "__is_secure__"
> but __secured__ is an attr of methods, __is_secure__ is of the class. I'd r
The distinction is not important; and the solution is more elegant with one __secured__ attribute.
Line 26: 
Line 27: 
Line 28: class SecureError(RuntimeError):
Line 29:     pass


-- 
To view, visit http://gerrit.ovirt.org/22115
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5a8be7536748481746795e27701fbecc7c3318c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list