Change in vdsm[master]: sp: changing un-shared treatment in the createVolume function
oourfali at redhat.com
oourfali at redhat.com
Thu Jan 16 10:03:45 UTC 2014
Oved Ourfali has posted comments on this change.
Change subject: sp: changing un-shared treatment in the createVolume function
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/23260/7/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Line 1842: srcVol = srcDom.produceVolume(imgUUID=srcImgUUID,
Line 1843: volUUID=srcVolUUID)
Line 1844: if not srcVol.isShared():
Line 1845: if srcVol.getParent() == volume.BLANK_UUID:
Line 1846: self.log.debug("volume %s is not shared. Setting it as shared",
> why pep8 job did not fail here?
noticed that.
Will push a fix.
Line 1847: srcVolUUID)
Line 1848: srcVol.setShared()
Line 1849: else:
Line 1850: raise se.VolumeNonShareable(srcVol)
--
To view, visit http://gerrit.ovirt.org/23260
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9a4b84795b176b9696684045e9774d324a42eca
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list