Change in vdsm[master]: volume: changing un-shared treatment in the share function

Federico Simoncelli fsimonce at redhat.com
Wed Jan 15 23:18:54 UTC 2014


Federico Simoncelli has posted comments on this change.

Change subject: volume: changing un-shared treatment in the share function
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/23260/5/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 299:         """
Line 300:         self.log.debug("Share volume %s to %s", self.volUUID, dstImgPath)
Line 301: 
Line 302:         if not self.isShared():
Line 303:             if self.getParent() == BLANK_UUID:
> just making sure: since this is run with an exclusive lock on our image, we
If we were allowing to createVolume on another image without the relevant lock it's a bug but it has nothing to do with this patch.
It's pretty much the same bug as receiving a deleteImage (on the template) while the createVolume is running.
Line 304:                 self.log.debug("Volume %s is not shared. Setting it as shared",
Line 305:                                self.volUUID)
Line 306:                 self.setShared()
Line 307:             else:


-- 
To view, visit http://gerrit.ovirt.org/23260
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9a4b84795b176b9696684045e9774d324a42eca
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list